Fix IntegralProblem deprecation error in tests #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix compatibility constraint preventing upgrade to PrecompileTools v1.3.x by allowing both v1.2.1 and v1.3 in Project.toml. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Removed domain patterns that expand to deprecated constructor signature.
The patterns (0.0, 1.0) and ([0.0], [1.0]) were causing the test to use
the deprecated IntegralProblem{iip}(f, lb, ub, p) constructor instead of
the new IntegralProblem{iip}(f, (lb, ub), p) constructor.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <[email protected]>
ChrisRackauckas
commented
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
test/function_building_error_messages.jlthat was causing tests to fail with--depwarn=error(0.0, 1.0)and([0.0], [1.0])that expand to the deprecatedIntegralProblem{iip}(f, lb, ub, p)constructor((0.0, 1.0),)and(([0.0], [1.0]),)that use the newIntegralProblem{iip}(f, (lb, ub), p)constructorTest plan
julia --depwarn=errorThis fix ensures that SciMLBase tests can run cleanly with deprecation warnings treated as errors, which is important for catching deprecation issues in CI.
🤖 Generated with Claude Code